Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): Make sure files get published #9611

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(deno): Make sure files get published #9611

merged 1 commit into from
Nov 21, 2023

Conversation

AbhiPrasad
Copy link
Member

Fixes #9609

Not sure how best to test this, suggestions are welcome! Will add tests in another PR to not unblock this though.

@AbhiPrasad AbhiPrasad requested a review from lforst November 21, 2023 01:25
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.61 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.72 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser - Webpack (gzipped) 21.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.03 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.71 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.85 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.92 KB (+0.13% 🔺)
@sentry/react - Webpack (gzipped) 21.36 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.66 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.15 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.12 KB (-0.25% 🔽)

@AbhiPrasad AbhiPrasad mentioned this pull request Nov 21, 2023
3 tasks
@mydea
Copy link
Member

mydea commented Nov 21, 2023

I guess we could add an E2E test? (in the future)

@lforst lforst merged commit 48e2337 into develop Nov 21, 2023
49 checks passed
@lforst lforst deleted the abhi-deno-files branch November 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import @sentry/deno
3 participants