Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(feedback): Rename onDialog* to onForm*, remove onActorClick #9625

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Nov 21, 2023

Rename the onDialogOpen and onDialogClose callbacks to onFormOpen and onFormClose to match our defined terminology and remove onActorClick as it's not necessary.

Closes #9605

@c298lee c298lee requested a review from a team November 21, 2023 15:57
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.62 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.73 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.02 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 21.33 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.05 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.14 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.27 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.75 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.42 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.38 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.86 KB (+0.04% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.93 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 21.37 KB (+0.06% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.67 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.16 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.1 KB (-0.11% 🔽)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@c298lee c298lee merged commit 387ce48 into develop Nov 21, 2023
81 checks passed
@c298lee c298lee deleted the rename-ondialog branch November 21, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename onDialog* callbacks to onForm*, remove onActorClick
2 participants