Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make full url customizable for Spotlight #9652

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: Make full url customizable for Spotlight #9652

merged 1 commit into from
Nov 24, 2023

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Nov 24, 2023

No description provided.

Lms24
Lms24 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we mandate /stream to be the URL since that's sidecar-internal. I probably missed that it's now configurable?

@HazAT
Copy link
Member Author

HazAT commented Nov 24, 2023

It's not but why just hardcode /stream? If we update the url in sidecar to something else there wouldn't even be a way for users to work around that

@HazAT HazAT merged commit 739d904 into develop Nov 24, 2023
67 checks passed
@HazAT HazAT deleted the fix/spotlight-full-custom-url branch November 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazAT @Lms24