-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Change to use preset quality values #9903
Merged
billyvg
merged 3 commits into
develop
from
feat-replay-add-canvas-recording-type-option
Dec 19, 2023
Merged
feat(replay): Change to use preset quality values #9903
billyvg
merged 3 commits into
develop
from
feat-replay-add-canvas-recording-type-option
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
feat-replay-add-canvas-recording-type-option
branch
from
December 18, 2023 21:11
f7834db
to
1da8803
Compare
size-limit report 📦
|
billyvg
changed the title
feat(replay): Add
feat(replay): Change to use preset quality values
Dec 18, 2023
canvas.type
setting
c298lee
approved these changes
Dec 18, 2023
mydea
reviewed
Dec 19, 2023
packages/replay/src/constants.ts
Outdated
quality: 0.25, | ||
}, | ||
}, | ||
normal: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd go with medium
over normal
here 🤔 but no strong feelings.
mydea
approved these changes
Dec 19, 2023
Instead of using canvas recording quality values direct to rrweb, use presets to control image quality and fps. Closes getsentry/team-replay#325
billyvg
force-pushed
the
feat-replay-add-canvas-recording-type-option
branch
from
December 19, 2023 16:33
825f18d
to
7acd14a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using canvas recording quality values direct to rrweb, use presets to control image quality and fps.
Closes https://github.com/getsentry/team-replay/issues/325