Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octane fixes #921

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Octane fixes #921

merged 2 commits into from
Jul 17, 2024

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Jul 15, 2024 •
edited
Loading

  • Stop holding a reference to the container in our middleware, this prevents us from correctly registering a terminating callback causing the request to not be traced (or possibly traces to be extremely long since they span multiple requests). This is Octane specific, works fine in a normal Laravel/Lumen context
  • As reported by Getting this error after switching production to roadrunner #917 in some cases (not 100% clear what) the route name can be a Closure, add a preventitive guard against that

@stayallive stayallive requested a review from cleptric July 15, 2024 13:45
@stayallive stayallive self-assigned this Jul 15, 2024
@stayallive stayallive merged commit bea6615 into master Jul 17, 2024
25 checks passed
@stayallive stayallive deleted the octane-fixes branch July 17, 2024 06:59
@GalahadXVI GalahadXVI mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

Assignees

@stayallive stayallive

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stayallive @cleptric