Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce optional handler strategy #1027

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

supervacuus
Copy link
Collaborator

This is a very early approach to fix #1026

This is mostly meant for integration in the alpha/beta build sequence of sentry-native, sentry-android, and sentry-dotnet to test against the dotnet-maui on the Android repro project.

No review is required at this stage, just feedback from the downstream test integration.

cc: @kahest, @bitsandfoxes, @markushi

#skip-changelog

…gy (which must work on all UNIXes) and the query towards the handler_strategy option which must only work on Linux.
Copy link

github-actions bot commented Aug 5, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d11359b

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (131a1ee) to head (d11359b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   83.75%   83.67%   -0.08%     
==========================================
  Files          53       53              
  Lines        5510     5526      +16     
  Branches     1197     1199       +2     
==========================================
+ Hits         4615     4624       +9     
- Misses        783      789       +6     
- Partials      112      113       +1     

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the detailed code comments, helped a lot. 🚀

@supervacuus
Copy link
Collaborator Author

LGTM! Thanks for the detailed code comments, helped a lot. 🚀

Great, thanks!

Just to clarify, I intended to provide this branch primarily for downstream testing. I will only merge/release once we know introducing this strategy solves the issue downstream. Also, there is still a TODO item (enable page allocator only when we have a native crash) in the PR that should be done before a merge, not counting any changes required after downstream feedback or adding integration tests that cover the new strategy.

@markushi
Copy link
Member

markushi commented Sep 2, 2024

Quick update: We published an alpha release for sentry-java (7.15.0-alpha1) for testing purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally allow the inproc handler to invoke the signal chain at the start
2 participants