-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce optional handler strategy #1027
base: master
Are you sure you want to change the base?
Conversation
…gy (which must work on all UNIXes) and the query towards the handler_strategy option which must only work on Linux.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 83.75% 83.67% -0.08%
==========================================
Files 53 53
Lines 5510 5526 +16
Branches 1197 1199 +2
==========================================
+ Hits 4615 4624 +9
- Misses 783 789 +6
- Partials 112 113 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the detailed code comments, helped a lot. 🚀
Great, thanks! Just to clarify, I intended to provide this branch primarily for downstream testing. I will only merge/release once we know introducing this strategy solves the issue downstream. Also, there is still a |
Quick update: We published an alpha release for |
This is a very early approach to fix #1026
This is mostly meant for integration in the alpha/beta build sequence of
sentry-native
,sentry-android
, andsentry-dotnet
to test against the dotnet-maui on the Android repro project.No review is required at this stage, just feedback from the downstream test integration.
cc: @kahest, @bitsandfoxes, @markushi
#skip-changelog