feat(graphene): Add span for grapqhl operation #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a span for a graphql operation to the graphene integration
szokeasaurusrex
previously requested changes
Jul 2, 2024
There was a problem hiding this comment.
Thank you for the contribution, and thanks for your patience as we work through our backlog of community PRs!
I noticed that your PR is still using our old, deprecated Hub APIs. We are going to need to replace these with the new corresponding Scope APIs before we can merge this PR. More information on how to do this is available in our Migration Guide.
Is this a change you are comfortable with making yourself, or do you need us to take over the PR?
szokeasaurusrex
changed the title
szokeasaurusrex
changed the title
|
I take the freedom to remove the hubs from the pr |
github-actions
bot
removed
the
Trigger: tests using secrets
antonpirker
approved these changes
Jul 25, 2024
|
Mostly looks good, see above |
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
github-actions
bot
removed
the
Trigger: tests using secrets
|
Committed your suggestions! Thanks a lot for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a span for a graphql operation to the graphene integration
Fixes #2765
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.