Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metrics): Update type hints for tag values #3156

Merged
merged 2 commits into from
Jun 12, 2024
Merged

ref(metrics): Update type hints for tag values #3156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d22c5d
ref(metrics): Update type hints for tag values
Jun 11, 2024
7cdb3f0
Merge branch 'master' into elias/metric-tag-value-type-hints
elramen Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions sentry_sdk/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from typing import Any
from typing import Callable
from typing import Dict
from typing import List
from typing import Mapping
from typing import NotRequired
from typing import Optional
Expand Down Expand Up @@ -173,14 +172,7 @@
MetricTagsInternal = Tuple[Tuple[str, str], ...]

# External representation of tags as a dictionary.
MetricTagValue = Union[
str,
int,
float,
None,
List[Union[int, str, float, None]],
Tuple[Union[int, str, float, None], ...],
]
MetricTagValue = Union[str, int, float, None]
MetricTags = Mapping[str, MetricTagValue]

# Value inside the generator for the metric value.
Expand Down
Loading