Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add span data to the transactions trace context #3374

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Add span data to the transactions trace context #3374

merged 4 commits into from
Jul 30, 2024

Conversation

antonpirker
Copy link
Member

Fixes #3372

@antonpirker antonpirker marked this pull request as ready for review July 30, 2024 10:49
szokeasaurusrex
szokeasaurusrex reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have some suggestions for the test

tests/tracing/test_misc.py Show resolved Hide resolved
tests/tracing/test_misc.py Outdated Show resolved Hide resolved
tests/tracing/test_misc.py Show resolved Hide resolved
@antonpirker antonpirker enabled auto-merge (squash) July 30, 2024 14:58
@antonpirker antonpirker merged commit f8e5d2f into master Jul 30, 2024
126 checks passed
@antonpirker antonpirker deleted the antonpirker/transaction-data branch July 30, 2024 15:10
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
@antonpirker @sentrivana
Add span data to the transactions trace context (#3374)
878bea7 
Fixes #3372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit transaction.data inside contexts.trace.data
2 participants
@antonpirker @szokeasaurusrex