Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(strawberry): Support Strawberry 0.239.2 #3491

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Sep 3, 2024

Update our Strawberry integration to support the latest versions of Strawberry, following upstream breaking changes which caused our tests to fail.

Closes #3490

Copy link

codecov bot commented Sep 3, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
11522 4 11518 1635
View the top 3 failed tests by shortest run time
tests.integrations.aws_lambda.test_aws test_init_error[python3.9]
Stack Traces | 15.8s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.11]
Stack Traces | 15.9s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.12]
Stack Traces | 16.7s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@szokeasaurusrex szokeasaurusrex changed the title feat(strawberry): Support Strawberry 0.239.1 feat(strawberry): Support Strawberry 0.239.2 Sep 3, 2024
Update our Strawberry integration to support the latest versions of Strawberry, following upstream breaking changes which caused our tests to fail.

Closes #3490

Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
@sentrivana
Copy link
Contributor

LGTM! Can't leave a comment because it's not part of the diff, but please also remove the errors part from the sync wrapper (l 312) so that it's consistent

@szokeasaurusrex szokeasaurusrex merged commit 9df2b21 into master Sep 3, 2024
121 of 124 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fix-strawberry branch September 3, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Strawberry release (0.239.0) breaks tests in master
2 participants