-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolinking broken in 0.69 #2267
Comments
@marandaneto no it's unrelated, it's because of the linked PR. |
I can confirm this. After upgrading to the latest RN 0.69-rc6 version and running
Please note the And after the upgrade, there is no Sentry-related packages in my As the OP said, this is most probably due to the removal of |
@marandaneto just as an headsup, we are planning on releasing 0.69.0 this week |
We're going to look into this, thanks for the heads up. Edit: maybe useful read: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md sentry-react-native/react-native.config.js Lines 11 to 16 in 8830dab
|
Additionally, we need to remove the Despite removing those fields, something is odd with Sentry CLI |
@lucas-zimerman iirc React Native has changed the way how it finds Addition of the new .xcode.env configuration file for more deterministically sourcing the node executable |
Edit: also facebook/react-native#33777 (comment) |
Another change for 0.69: when using XCode, there is now a It comes with a The bundle build step becomes something like: export SENTRY_PROPERTIES=sentry.properties
export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export PROJECT_ROOT=$PWD/..
export NODE_MODULES_ROOT=$PROJECT_ROOT/../../node_modules
WITH_ENVIRONMENT="$NODE_MODULES_ROOT/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="$NODE_MODULES_ROOT/react-native/scripts/react-native-xcode.sh"
$WITH_ENVIRONMENT $NODE_MODULES_ROOT/expo-constants/scripts/get-app-config-ios.sh
$WITH_ENVIRONMENT $NODE_MODULES_ROOT/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE Unfortunately, this breaks
I guess the CLI does not properly looks up its arguments, and as it is wrapped by |
I'm currently working on a troubleshooting page with a workaround in order to unblock folks. |
Found an related issue => adjust/react_native_sdk#186 |
I can verify that Sentry is being removed while running pod install on 0.69.0.
|
@matinzd for now there's a quick workaround: Do that and install pods again. |
I was able to apply the patch for the react-native.config.js file as noted in the workaround. However I simply added these two lines:
in the .xcode.env file and left the default shellScript in project.pbxproj
Everything seems happy so far.... |
@mysport12 That's fine but if you do that and skip the |
It would be great if we can respect |
That's already possible, See docs getsentry/sentry-docs#5240 |
Thank you so much for the info! |
Hi there! Just checking on that status of this? Should I not wait and just go w/ the workaround? |
Any update on release fix ? |
The patch from @marandaneto has been approved by @kamilogorek : getsentry/sentry-wizard#173 (review) Manoel is back online tomorrow so we should see this patch merged, and a new release of sentry-wizard coming out soon. Sorry for the delay on this one folks. |
I'll release a new version once https://github.com/getsentry/sentry-wizard |
Going to be released as 5.0.0-alpha.0 |
Due to react-native-community/cli#1537 some things in your
react-native.config.js
have been deprecated and removed, thus failing autolinking schema validation (for exampleios.sharedLibraries
).Steps to Reproduce
npx react-native init Example --version 0.69.0-rc.6
.The text was updated successfully, but these errors were encountered: