Autolinking broken in 0.69 #2267

oblador · 2022-06-07T10:32:12Z

Due to react-native-community/cli#1537 some things in your react-native.config.js have been deprecated and removed, thus failing autolinking schema validation (for example ios.sharedLibraries).

Steps to Reproduce

Create a vanilla RN project with latest 0.69 RC with npx react-native init Example --version 0.69.0-rc.6.
Add this package.
Observe it not being autolinked.

The text was updated successfully, but these errors were encountered:

marandaneto · 2022-06-07T12:27:14Z

Thanks @oblador we will have a look at it.
Likely a side effect of #2226

oblador · 2022-06-07T12:56:52Z

@marandaneto no it's unrelated, it's because of the linked PR.

renchap · 2022-06-21T22:20:46Z

I can confirm this.

After upgrading to the latest RN 0.69-rc6 version and running pod update, I get:

Downloading dependencies
Installing DoubleConversion 1.1.6
Installing FBLazyVector 0.69.0-rc.6 (was 0.68.2)
Installing FBReactNativeSpec 0.69.0-rc.6 (was 0.68.2)
Installing Flipper-DoubleConversion 3.2.0.1 (was 3.2.0)
Installing Flipper-Glog 0.5.0.5 (was 0.5.0.4)
Installing RCTRequired 0.69.0-rc.6 (was 0.68.2)
Installing RCTTypeSafety 0.69.0-rc.6 (was 0.68.2)
Installing RNReanimated 2.8.0
Installing React 0.69.0-rc.6 (was 0.68.2)
Installing React-Codegen 0.69.0-rc.6 (was 0.68.2)
Installing React-Core 0.69.0-rc.6 (was 0.68.2)
Installing React-CoreModules 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTActionSheet 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTAnimation 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTBlob 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTImage 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTLinking 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTNetwork 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTSettings 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTText 0.69.0-rc.6 (was 0.68.2)
Installing React-RCTVibration 0.69.0-rc.6 (was 0.68.2)
Installing React-bridging (0.69.0-rc.6)
Installing React-callinvoker 0.69.0-rc.6 (was 0.68.2)
Installing React-cxxreact 0.69.0-rc.6 (was 0.68.2)
Installing React-jsi 0.69.0-rc.6 (was 0.68.2)
Installing React-jsiexecutor 0.69.0-rc.6 (was 0.68.2)
Installing React-jsinspector 0.69.0-rc.6 (was 0.68.2)
Installing React-logger 0.69.0-rc.6 (was 0.68.2)
Installing React-perflogger 0.69.0-rc.6 (was 0.68.2)
Installing React-runtimeexecutor 0.69.0-rc.6 (was 0.68.2)
Installing ReactCommon 0.69.0-rc.6 (was 0.68.2)
Installing Yoga 1.14.0
Installing glog 0.3.5
Removing Sentry
Generating Pods project

Please note the Removing Sentry line.

And after the upgrade, there is no Sentry-related packages in my Podfile.lock.

As the OP said, this is most probably due to the removal of react-native link command and the refactor of auto-linking made in the PR mentioned above.

kelset · 2022-06-22T10:53:19Z

@marandaneto just as an headsup, we are planning on releasing 0.69.0 this week

marandaneto · 2022-06-22T12:02:31Z

@marandaneto just as an headsup, we are planning on releasing 0.69.0 this week

We're going to look into this, thanks for the heads up.

Edit: maybe useful read: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
hooks were removed so there's a problem when doing this:

sentry-react-native/react-native.config.js

Lines 11 to 16 in 8830dab

    
           hooks: { 
        
             postlink: 
        
               'node node_modules/@sentry/wizard/dist/bin.js -i reactNative -p ios android', 
        
             postunlink: 
        
               'node node_modules/@sentry/wizard/dist/bin.js -i reactNative -p ios android --uninstall' 
        
           }

lucas-zimerman · 2022-06-22T16:20:07Z

Additionally, we need to remove the sharedLibraries from react-native.configs in order to allow the auto link to happen.
Or add a filter to not include those fields if running 0.69 or higher ( if that's possible)

Despite removing those fields, something is odd with Sentry CLI

Not sure which file or folder is missing.

marandaneto · 2022-06-23T09:14:56Z

@lucas-zimerman iirc React Native has changed the way how it finds node, it could be related to that.
https://reactnative.dev/blog/2022/06/21/version-069#highlights-of-069

Addition of the new .xcode.env configuration file for more deterministically sourcing the node executable

marandaneto · 2022-06-23T11:59:08Z

sentry-wizard patches the xcode project file in order to be able to auto-upload debug symbols.
The default code script has changed https://github.com/facebook/react-native/blob/main/template/ios/HelloWorld.xcodeproj/project.pbxproj#L267=
and I guess that sentry-wizard is replacing its default react-native configuration, this could also be the culprit for sentry-cli to fail.

Edit: also facebook/react-native#33777 (comment)

renchap · 2022-06-24T09:17:47Z

Another change for 0.69: when using XCode, there is now a .xcode.env file that allows you to set the proper environment variables for the bundle build step, for example $NODE_BINARY.

It comes with a react-native/scripts/xcode/with-environment.sh script that will set the env var, then call its argument.

The bundle build step becomes something like:

export SENTRY_PROPERTIES=sentry.properties
export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export PROJECT_ROOT=$PWD/..
export NODE_MODULES_ROOT=$PROJECT_ROOT/../../node_modules

WITH_ENVIRONMENT="$NODE_MODULES_ROOT/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="$NODE_MODULES_ROOT/react-native/scripts/react-native-xcode.sh"

$WITH_ENVIRONMENT $NODE_MODULES_ROOT/expo-constants/scripts/get-app-config-ios.sh
$WITH_ENVIRONMENT $NODE_MODULES_ROOT/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE

Unfortunately, this breaks @sentry/cli and I am not sure why:

Node found at: /Users/renchap/.nvm/versions/node/v16.14.0/bin/node # <== this is the first `with-environment.sh` call for expo-constants
Node found at: /Users/renchap/.nvm/versions/node/v16.14.0/bin/node # <== this is the second `with-environment.sh` call for sentry-cli
sentry-cli 1.74.4

Command line utility for Sentry.

This tool helps you manage remote resources on a Sentry server like
sourcemaps, debug symbols or releases.  Use `--help` on the subcommands
to learn more about them.

USAGE:
    sentry-cli <SUBCOMMAND>

OPTIONS:
        --api-key <API_KEY>          The given Sentry API key.
        --auth-token <AUTH_TOKEN>    Use the given Sentry auth token.
    -h, --help                       Print this help message.
        --log-level <LOG_LEVEL>      Set the log output verbosity. [possible values: trace, debug,
                                     info, warn, error]
        --url <URL>                  Fully qualified URL to the Sentry server.
                                     [defaults to https://sentry.io/]
    -V, --version                    Print version information.

SUBCOMMANDS:
    bash-hook          Prints out a bash script that does error handling.
    difutil            Locate or analyze debug information files.
    help               Prints this message or the help of the given subcommand(s)
    info               Print information about the Sentry server.
    issues             Manage issues in Sentry.
    login              Authenticate with the Sentry server.
    projects           Manage projects on Sentry.
    react-native       Upload build artifacts for react-native projects.
    releases           Manage releases on Sentry.
    repos              Manage repositories on Sentry.
    send-event         Send a manual event to Sentry.
    upload-dif         Upload debugging information files.
    upload-proguard    Upload ProGuard mapping files to a project.

I guess the CLI does not properly looks up its arguments, and as it is wrapped by with-environment.sh it tries to parse sentry-cli as an argument?

marandaneto · 2022-06-24T10:15:18Z

I'm currently working on a troubleshooting page with a workaround in order to unblock folks.
getsentry/sentry-docs#5208 -> preview
We'll work on a fix as soon as we know what has to be changed.

ken0nek · 2022-06-24T22:00:19Z

Found an related issue => adjust/react_native_sdk#186

matinzd · 2022-06-25T03:52:21Z

I can verify that Sentry is being removed while running pod install on 0.69.0.

Installing FBLazyVector 0.69.0 (was 0.68.2)
Installing FBReactNativeSpec 0.69.0 (was 0.68.2)
Installing Flipper-DoubleConversion 3.2.0.1 (was 3.2.0)
Installing Flipper-Glog 0.5.0.5 (was 0.5.0.4)
Installing RCTRequired 0.69.0 (was 0.68.2)
Installing RCTTypeSafety 0.69.0 (was 0.68.2)
Installing RNReanimated 2.8.0
Installing React 0.69.0 (was 0.68.2)
Installing React-Codegen 0.69.0 (was 0.68.2)
Installing React-Core 0.69.0 (was 0.68.2)
Installing React-CoreModules 0.69.0 (was 0.68.2)
Installing React-RCTActionSheet 0.69.0 (was 0.68.2)
Installing React-RCTAnimation 0.69.0 (was 0.68.2)
Installing React-RCTBlob 0.69.0 (was 0.68.2)
Installing React-RCTImage 0.69.0 (was 0.68.2)
Installing React-RCTLinking 0.69.0 (was 0.68.2)
Installing React-RCTNetwork 0.69.0 (was 0.68.2)
Installing React-RCTSettings 0.69.0 (was 0.68.2)
Installing React-RCTText 0.69.0 (was 0.68.2)
Installing React-RCTVibration 0.69.0 (was 0.68.2)
Installing React-bridging (0.69.0)
Installing React-callinvoker 0.69.0 (was 0.68.2)
Installing React-cxxreact 0.69.0 (was 0.68.2)
Installing React-jsi 0.69.0 (was 0.68.2)
Installing React-jsiexecutor 0.69.0 (was 0.68.2)
Installing React-jsinspector 0.69.0 (was 0.68.2)
Installing React-logger 0.69.0 (was 0.68.2)
Installing React-perflogger 0.69.0 (was 0.68.2)
Installing React-runtimeexecutor 0.69.0 (was 0.68.2)
Installing ReactCommon 0.69.0 (was 0.68.2)
Installing Yoga 1.14.0
Installing react-native-render-html (6.3.4)
Removing Sentry

marandaneto · 2022-06-25T08:52:01Z

@matinzd for now there's a quick workaround:
https://docs.sentry.io/platforms/react-native/troubleshooting/#react-native-069-and-higher

Do that and install pods again.

mysport12 · 2022-06-30T02:40:53Z

I was able to apply the patch for the react-native.config.js file as noted in the workaround.

However I simply added these two lines:

export SENTRY_PROPERTIES=sentry.properties
export EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"

in the .xcode.env file and left the default shellScript in project.pbxproj

shellScript = "set -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n";

Everything seems happy so far....

marandaneto · 2022-06-30T08:00:29Z

@mysport12 That's fine but if you do that and skip the sentry-cli part, you've to upload the bundle and source maps manually to Sentry, in this case, you don't even need the export SENTRY_PROPERTIES=sentry.properties either.

ken0nek · 2022-06-30T19:14:26Z

It would be great if we can respect .xcode.env, keep WITH_ENVIRONMENT and also make sentry work. Will take a look.

marandaneto · 2022-07-01T06:03:28Z

It would be great if we can respect .xcode.env, keep WITH_ENVIRONMENT and also make sentry work. Will take a look.

That's already possible, See docs getsentry/sentry-docs#5240

ken0nek · 2022-07-01T06:26:52Z

Thank you so much for the info!

jmz527 · 2022-07-12T21:18:25Z

Hi there! Just checking on that status of this? Should I not wait and just go w/ the workaround?

sunchanras · 2022-07-19T03:08:18Z

Any update on release fix ?

bruno-garcia · 2022-07-19T19:42:49Z

The patch from @marandaneto has been approved by @kamilogorek : getsentry/sentry-wizard#173 (review)

Manoel is back online tomorrow so we should see this patch merged, and a new release of sentry-wizard coming out soon. Sorry for the delay on this one folks.

marandaneto · 2022-07-21T06:56:08Z

I'll release a new version once https://github.com/getsentry/sentry-wizard 2.0.0 and #2332 gets released.

marandaneto · 2022-07-22T11:24:30Z

Going to be released as 5.0.0-alpha.0

github-actions bot added the Platform: React-Native label Jun 7, 2022

marandaneto added Type: 🪲 Bug Status: Backlog labels Jun 13, 2022

marandaneto mentioned this issue Jun 24, 2022

Troubleshooting entry for RN autolinking getsentry/sentry-docs#5208

Merged

marandaneto added Effort: Medium labels Jun 24, 2022

This was referenced Jun 30, 2022

Fix: Auto linking for RN >= 0.69 #2332

Merged

v4: Unresolved reference: sentry #2331

Closed

marandaneto mentioned this issue Jul 1, 2022

Patching React Native files on React Native 0.69 and higher (iOS only) getsentry/sentry-wizard#172

Closed

marandaneto pinned this issue Jul 3, 2022

This was referenced Jul 3, 2022

SentryError: Native Client is not available, can't start on native #2335

Closed

@sentry/react-native has been ignored because it contains invalid configuration. "dependency.platforms.ios.sharedLibraries" #2343

Closed

marandaneto mentioned this issue Jul 7, 2022

Patch React Native xcode RN 0.69 getsentry/sentry-wizard#173

Merged

marandaneto closed this as completed in getsentry/sentry-wizard#173 Jul 21, 2022

marandaneto reopened this Jul 21, 2022

marandaneto closed this as completed Jul 22, 2022

marandaneto added this to the 5.0.0 milestone Aug 17, 2022

getsentry locked and limited conversation to collaborators Aug 30, 2022

kahest unpinned this issue Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autolinking broken in 0.69 #2267

Autolinking broken in 0.69 #2267

oblador commented Jun 7, 2022

marandaneto commented Jun 7, 2022

oblador commented Jun 7, 2022

renchap commented Jun 21, 2022

kelset commented Jun 22, 2022

marandaneto commented Jun 22, 2022 •

edited

Loading

lucas-zimerman commented Jun 22, 2022 •

edited

Loading

marandaneto commented Jun 23, 2022

marandaneto commented Jun 23, 2022 •

edited

Loading

renchap commented Jun 24, 2022

marandaneto commented Jun 24, 2022 •

edited

Loading

ken0nek commented Jun 24, 2022

matinzd commented Jun 25, 2022 •

edited

Loading

marandaneto commented Jun 25, 2022 •

edited

Loading

mysport12 commented Jun 30, 2022

marandaneto commented Jun 30, 2022

ken0nek commented Jun 30, 2022

marandaneto commented Jul 1, 2022

ken0nek commented Jul 1, 2022

jmz527 commented Jul 12, 2022

sunchanras commented Jul 19, 2022

bruno-garcia commented Jul 19, 2022

marandaneto commented Jul 21, 2022 •

edited

Loading

marandaneto commented Jul 22, 2022

Autolinking broken in 0.69 #2267

Autolinking broken in 0.69 #2267

Comments

oblador commented Jun 7, 2022

Steps to Reproduce

marandaneto commented Jun 7, 2022

oblador commented Jun 7, 2022

renchap commented Jun 21, 2022

kelset commented Jun 22, 2022

marandaneto commented Jun 22, 2022 • edited Loading

lucas-zimerman commented Jun 22, 2022 • edited Loading

marandaneto commented Jun 23, 2022

marandaneto commented Jun 23, 2022 • edited Loading

renchap commented Jun 24, 2022

marandaneto commented Jun 24, 2022 • edited Loading

ken0nek commented Jun 24, 2022

matinzd commented Jun 25, 2022 • edited Loading

marandaneto commented Jun 25, 2022 • edited Loading

mysport12 commented Jun 30, 2022

marandaneto commented Jun 30, 2022

ken0nek commented Jun 30, 2022

marandaneto commented Jul 1, 2022

ken0nek commented Jul 1, 2022

jmz527 commented Jul 12, 2022

sunchanras commented Jul 19, 2022

bruno-garcia commented Jul 19, 2022

marandaneto commented Jul 21, 2022 • edited Loading

marandaneto commented Jul 22, 2022

marandaneto commented Jun 22, 2022 •

edited

Loading

lucas-zimerman commented Jun 22, 2022 •

edited

Loading

marandaneto commented Jun 23, 2022 •

edited

Loading

marandaneto commented Jun 24, 2022 •

edited

Loading

matinzd commented Jun 25, 2022 •

edited

Loading

marandaneto commented Jun 25, 2022 •

edited

Loading

marandaneto commented Jul 21, 2022 •

edited

Loading