-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch React Native xcode RN 0.69 #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit (merged it myself), feel free to merge after tests pass.
@kamilogorek and @bruno-garcia If I got it right -> https://classic.yarnpkg.com/en/docs/dependency-versions#toc-caret-ranges |
This reverts commit c1885d2.
Fix getsentry/sentry-react-native#2267
No need of doing https://docs.sentry.io/platforms/react-native/troubleshooting/#react-native-069-and-higher manually
We should bump a minor 1.3.0 since it's not compatible with RN < 0.69
Next: uninstall steps are broken already even for the current version of RN.
Wondering if we should get rid of the uninstall patches or not.
https://github.com/getsentry/sentry-wizard/pull/66/files Adds
EXTRA_PACKAGER_ARGS
but does not remove it during uninstall steps.It does not unpatch the App.js that calls
Sentry.init
.It does not delete the sentry.properties files, but just comment the fields such as
#defaults.org=
.