Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch React Native xcode RN 0.69 #173

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 7, 2022

Fix getsentry/sentry-react-native#2267
No need of doing https://docs.sentry.io/platforms/react-native/troubleshooting/#react-native-069-and-higher manually
We should bump a minor 1.3.0 since it's not compatible with RN < 0.69

Next: uninstall steps are broken already even for the current version of RN.
Wondering if we should get rid of the uninstall patches or not.
https://github.com/getsentry/sentry-wizard/pull/66/files Adds EXTRA_PACKAGER_ARGS but does not remove it during uninstall steps.
It does not unpatch the App.js that calls Sentry.init.
It does not delete the sentry.properties files, but just comment the fields such as #defaults.org=.

@marandaneto marandaneto marked this pull request as ready for review July 8, 2022 11:46
lib/Steps/Integrations/ReactNative.ts Show resolved Hide resolved
lib/Steps/Integrations/ReactNative.ts Show resolved Hide resolved
lib/Steps/Integrations/ReactNative.ts Show resolved Hide resolved
lib/Steps/Integrations/ReactNative.ts Show resolved Hide resolved
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit (merged it myself), feel free to merge after tests pass.

package.json Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor Author

@kamilogorek and @bruno-garcia If I got it right -> https://classic.yarnpkg.com/en/docs/dependency-versions#toc-caret-ranges
Releasing Sentry Wizard as 1.3.0 won't help React Native because older versions of the SDK use the ^1.2.17 syntax and 1.3.0 is a valid range within the ^1.2.17 definition.
We'd need to release Sentry Wizard as 2.0.0 so older versions of the React Native SDK would look up for 1.2.17, and newer versions would pin to 2.0.0, keeping retro compatibility, is that right?

@marandaneto marandaneto merged commit c1885d2 into master Jul 21, 2022
@marandaneto marandaneto deleted the chore/patch-xcode-rn069 branch July 21, 2022 05:05
marandaneto added a commit that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolinking broken in 0.69
2 participants