Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autolinking): Restore RNSentry xcode project used for autolinking in older RN versions #2980

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Apr 19, 2023

📢 Type of change

  • Bugfix

📜 Description

Removed in https://github.com/getsentry/sentry-react-native/pull/2707/files#diff-accdc83031ad6cc664dfc3a76eba7d3f3d9c74ca4512a7c538af2b2a949c0398

RN CLI requires xcode project for autolinking 0.68 and older
https://github.com/react-native-community/cli/blob/7a10b39160d53caf43f36ae9e62d4bed942003ea/packages/platform-ios/src/config/index.ts#L41-L48

The project is just a dummy, Podfile is used.

💡 Motivation and Context

#2956

💚 How did you test it?

generated older app, ci

https://github.com/getsentry/sentry-react-native/actions/runs/4742862644/jobs/8421660685?pr=2980#step:16:16

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.60 ms 406.20 ms 28.60 ms
Size 17.73 MiB 19.75 MiB 2.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3 385.02 ms 387.36 ms 2.34 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms

App size

Revision Plain With Sentry Diff
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1261.64 ms 1295.08 ms 33.44 ms
Size 2.36 MiB 2.84 MiB 488.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1288.96 ms 1304.56 ms 15.60 ms
Size 2.92 MiB 3.40 MiB 494.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 280.10 ms 325.52 ms 45.42 ms
Size 7.15 MiB 8.04 MiB 912.17 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) April 21, 2023 15:42
@krystofwoldrich krystofwoldrich merged commit ad6c299 into main Apr 21, 2023
@krystofwoldrich krystofwoldrich deleted the kw-restore-rnsentry-xcode-project branch April 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants