Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add easy enabled splits and flavors in RN Android samples #4157

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Enhancement

📜 Description

This PR adds splits and flavors to the RN Android Sample with easy to run packager script to test issues like #4125

💚 How did you test it?

local builds

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.46 ms 425.54 ms 33.08 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
4a6664f+dirty 357.02 ms 394.91 ms 37.89 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
4a6664f+dirty 7.15 MiB 8.22 MiB 1.07 MiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB

Copy link
Contributor

github-actions bot commented Oct 7, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.02 ms 1228.47 ms 2.45 ms
Size 2.36 MiB 3.13 MiB 784.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
c398f67+dirty 1219.67 ms 1225.66 ms 5.99 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
baa882f+dirty 1218.00 ms 1227.04 ms 9.04 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms

App size

Revision Plain With Sentry Diff
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
c398f67+dirty 2.36 MiB 3.04 MiB 696.27 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
baa882f+dirty 2.36 MiB 3.08 MiB 731.91 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB

Copy link
Contributor

github-actions bot commented Oct 7, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.72 ms 1224.35 ms 4.62 ms
Size 2.92 MiB 3.69 MiB 791.09 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
baa882f+dirty 1235.48 ms 1229.02 ms -6.46 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms

App size

Revision Plain With Sentry Diff
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
baa882f+dirty 2.92 MiB 3.64 MiB 738.56 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 456.00 ms 460.84 ms 4.84 ms
Size 17.73 MiB 20.10 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
4a6664f 548.79 ms 585.00 ms 36.21 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
27ef4ee 317.40 ms 321.70 ms 4.30 ms
148f924 492.65 ms 500.28 ms 7.63 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
4a6664f 17.73 MiB 19.94 MiB 2.21 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected 🚀
Thank you for this enhancement @krystofwoldrich 🙇

@antonis antonis merged commit 46b60ab into main Oct 8, 2024
65 checks passed
@antonis antonis deleted the kw-android-sample-splits-flavors branch October 8, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants