Only extend ActiveJob when it's defined #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
+ Coverage 97.92% 98.79% +0.86%
==========================================
Files 193 28 -165
Lines 8249 746 -7503
==========================================
- Hits 8078 737 -7341
+ Misses 171 9 -162
Continue to review full report at Codecov.
|
It's somewhat common for Rails users to exclude ActiveJob by manually requiring every other components when they don't need it. So we should detect if the ActiveJob constant is defined before extending it.
|
Thanks for this! I bumped into it while migrating from Do you think you could release a patch version of this to rubygems.org? This is working perfectly locally: gem "sentry-rails", github: "getsentry/sentry-ruby", glob: "sentry-rails/*.gemspec"
gem "sentry-ruby", github: "getsentry/sentry-ruby", glob: "sentry-ruby/*.gemspec"But the Sentry transactions aren't being reported from Heroku. Wondering if it's Git-related due to some logs but, still investigating: |
|
I'll release gem "sentry-rails", github: "getsentry/sentry-ruby"
gem "sentry-ruby", github: "getsentry/sentry-ruby" |
|
@croaky well it's been released in version 4.1.5 now 🙂 |
|
Thanks @st0012! |
choznerol
added a commit
to choznerol/sentry-ruby
that referenced
this pull request
Dec 9, 2021
similar to the way we treat ActiveJobExtensions in getsentry#1218
choznerol
added a commit
to choznerol/sentry-ruby
that referenced
this pull request
Dec 9, 2021
similar to the way we treat ActiveJobExtensions in getsentry#1218
choznerol
pushed a commit
to choznerol/sentry-ruby
that referenced
this pull request
Dec 9, 2021
getsentry@3ae1365 There are 5 types of hooks that Action Cable provides: * `Connection#connect` * `Connection#disconnect` * `Channel#subscribed` * `Channel#unsubscribed` * `Channel` actions Now, any exceptions raised within those hooks are captured by Sentry, and reported as `ActionCable/[...]` transactions. Additional context is included depending on the hook the exception was raised within. A note/quirk: the Rack env that's included in the scope is from the `Connection`, and therefore has a URL of the cable `mount_path` (usually `/cable`) as well as the headers from that initial connection request. Additionally, there is not currently a really clean way to hook in and set `user_context`. I don't know if that is a blocker for this integration, but wanted to make sure it was noted.
choznerol
added a commit
to choznerol/sentry-ruby
that referenced
this pull request
Dec 9, 2021
Similar to the update for ActiveJobExtensions in getsentry#1218
choznerol
added a commit
to choznerol/sentry-ruby
that referenced
this pull request
Dec 9, 2021
Similar to the update for ActionCableExtensions in getsentry#1218 and getsentry#1494
st0012
pushed a commit
that referenced
this pull request
Dec 12, 2021
…tion of #1295) (#1638) * capture exceptions in Action Cable connections and channels There are 5 types of hooks that Action Cable provides: * `Connection#connect` * `Connection#disconnect` * `Channel#subscribed` * `Channel#unsubscribed` * `Channel` actions Now, any exceptions raised within those hooks are captured by Sentry, and reported as `ActionCable/[...]` transactions. Additional context is included depending on the hook the exception was raised within. A note/quirk: the Rack env that's included in the scope is from the `Connection`, and therefore has a URL of the cable `mount_path` (usually `/cable`) as well as the headers from that initial connection request. Additionally, there is not currently a really clean way to hook in and set `user_context`. I don't know if that is a blocker for this integration, but wanted to make sure it was noted. * Only extend ActionCable when it's defined Similar to the update for ActionCableExtensions in #1218 and #1494 * test(ActionCable): Assert only 1 event captured: #1295 #1295 * Remove namespace 'ActionCable/*' #1295 * Test ActionCable #unsubscribed #1295 * test(ActionCable): prefer rspec-rails over mini-test #1295 (comment) * test(ActionCable): cleanup duplicated set_callback * docs(CHANGELOG): update #1295 to #1638 Co-authored-by: Alex Robbin <agrobbin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's somewhat common for Rails users to exclude ActiveJob by manually
requiring every other components when they don't need it. So we should
detect if the ActiveJob constant is defined before extending it.
Fixes #1210