Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolated tests to sentry-rails #1497

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Add isolated tests to sentry-rails #1497

merged 3 commits into from
Jul 4, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jul 4, 2021

Some initialization logics are hard to test with the normal RSpec setup. Isolate each cases into their own files will make it easier (but also slower).

@st0012 st0012 added this to the 4.7.0 milestone Jul 4, 2021
@st0012 st0012 self-assigned this Jul 4, 2021
@st0012 st0012 changed the title Add isolation tests to sentry-rails Add isolated tests to sentry-rails Jul 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #1497 (bbec128) into master (083a0d6) will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   98.21%   98.77%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10553     6716    -3837     
==========================================
- Hits        10365     6634    -3731     
+ Misses        188       82     -106     
Impacted Files Coverage Δ
sentry-raven/spec/raven/client_state_spec.rb
sentry-raven/lib/raven/backtrace.rb
sentry-raven/lib/raven/interface.rb
sentry-raven/spec/raven/integrations/rails_spec.rb
sentry-raven/lib/raven/cli.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
sentry-raven/lib/raven/processor/cookies.rb
...entry-raven/lib/raven/breadcrumbs/sentry_logger.rb
...lib/raven/integrations/rails/controller_methods.rb
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083a0d6...bbec128. Read the comment docs.

@st0012 st0012 merged commit 7b9f8fc into master Jul 4, 2021
@st0012 st0012 deleted the add-isolation-tests branch July 4, 2021 07:52
@st0012 st0012 modified the milestones: 4.7.0, 4.6.1 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants