Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract envelope construction logic from Transport #1616

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Nov 12, 2021

Closes #1611

@st0012 st0012 added this to the 5.0.0 milestone Nov 12, 2021
@st0012 st0012 self-assigned this Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1616 (2a45d15) into master (7aab67c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1616   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         131      132    +1     
  Lines        7322     7332   +10     
=======================================
+ Hits         7212     7222   +10     
  Misses        110      110           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/envelope.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transport.rb 98.80% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aab67c...2a45d15. Read the comment docs.

@st0012
Copy link
Collaborator Author

st0012 commented Nov 12, 2021

@sl0thentr0py does this look like what you'd expect?

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st0012 yes that looks great!

@st0012 st0012 merged commit 0119cd4 into master Nov 17, 2021
@st0012 st0012 deleted the implement-#1611 branch November 17, 2021 19:18
@st0012 st0012 modified the milestones: 5.0.0, 4.8.1 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Envelope/Item classes
3 participants