Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faraday from tests #1622

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Remove faraday from tests #1622

merged 2 commits into from
Nov 21, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Nov 19, 2021

This is the first step of removing faraday from dependencies: instead of using its stubbing helpers, we can build a set of slightly lower-level helpers to replace them. I've already done a similar thing in net/http_spec so we can reuse most of the concept here.

@st0012 st0012 added this to the 4.8.1 milestone Nov 19, 2021
@st0012 st0012 self-assigned this Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #1622 (681e263) into master (23c66f5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 681e263 differs from pull request most recent head 3bd2296. Consider uploading reports for the commit 3bd2296 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   98.50%   98.50%   -0.01%     
==========================================
  Files         132      133       +1     
  Lines        7341     7336       -5     
==========================================
- Hits         7231     7226       -5     
  Misses        110      110              
Impacted Files Coverage Δ
sentry-ruby/spec/contexts/with_request_mock.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
...try/transport/http_transport_rate_limiting_spec.rb 99.11% <100.00%> (-0.04%) ⬇️
...-ruby/spec/sentry/transport/http_transport_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c66f5...3bd2296. Read the comment docs.

@st0012 st0012 merged commit b61bc0d into master Nov 21, 2021
@st0012 st0012 deleted the remove-faraday-from-tests branch November 21, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants