Fixup Net::HTTP breadcrumb url & span creation when Net::HTTP.start is used

[ojab]

Please keep these instructions in mind so we can review it more efficiently:

Right now we're not recording URL and creating single span for all the requests.

Description

Not sure if body addition is a welcome change and if 100 is a good length, but it would be useful for us.

[ojab]

CI failure is unrelated and I will update changelog with PR number anyway, so sending to review.

[ojab]

OTOH breadcrumbs are already limiting max message size since https://github.com/getsentry/sentry-ruby/pull/1465/files, so limiting body size could be dropped

[st0012]

@ojab thanks for the PR. I think they're both good additions but we can't add those information directly as it may contain pii data. we should only add them when Sentry.configuration.send_default_pii is true, like

sentry-ruby/sentry-ruby/lib/sentry/interfaces/request.rb

Lines 40 to 44 in efcf170

	if Sentry.configuration.send_default_pii
	self.data = read_data_from(request)
	self.cookies = request.cookies
	self.query_string = request.query_string
	end

[ojab]

Yeah, I saw that and guessed that only incoming stuff is counted as PII.
I'll make a change to save query & body only with send_default_pii probably tomorrow then.

[ojab]

Updated, CI is green.

[ojab]

Also pushed commit to fix tracing of multiple requests in a single connection.

[st0012]

@ojab it looks like you've made a few other changes to address different issues? since you're essentially rewriting the Net::HTTP patch, can you separate the changes for different issues/features? it'll help me review this more carefully, as it's an important feature of the SDK. thanks.

[st0012]

also, the feature and fixes will likely go out separately (feature in 4.9.0 while bug fixes in 4.8.x, depending on the impact).

[ojab]

Left only bugfixes in this PR and moved query string & body addition to the new PR #1642. Every change is split per-commit, so hope two PRs are ok.

[codecov-commenter]

Codecov Report

Merging #1637 (dacc310) into master (ce10521) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1637   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         135      135           
  Lines        7505     7511    +6     
=======================================
+ Hits         7389     7395    +6     
  Misses        116      116           

Impacted Files	Coverage Δ
sentry-ruby/lib/sentry/net/http.rb	100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce10521...dacc310. Read the comment docs.

[ojab]

Hey, any changes to be done here?

[st0012]

@ojab hey sorry I'm quite busy recently so haven't got time to check all the PRs yet.

[st0012]

Thanks for the fix!