Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage creation for head SDK #1898

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 15, 2022

Creates new Baggage entries when the ruby SDK is the head SDK, i.e the first SDK that originates a distributed trace.
The new Baggage entry is created when get_baggage is first called, either

  • when the first outgoing HTTP request is made
  • the first transaction finishes and the envelope is sent to sentry

closes #1836

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 96.67% // Head: 96.72% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a605ce7) compared to base (8b8af16).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           neel/baggage-dsc-continuation    #1898      +/-   ##
=================================================================
+ Coverage                          96.67%   96.72%   +0.05%     
=================================================================
  Files                                124      124              
  Lines                               7808     7903      +95     
=================================================================
+ Hits                                7548     7644      +96     
+ Misses                               260      259       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/baggage.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/span.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction_event.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/client_spec.rb 97.25% <100.00%> (+0.01%) ⬆️
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review September 19, 2022 10:58
sentry-ruby/lib/sentry/transaction.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/transaction.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/transaction.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/transaction.rb Outdated Show resolved Hide resolved
@st0012 st0012 added this to the 5.5.0 milestone Sep 19, 2022
@sl0thentr0py sl0thentr0py merged commit 8fae12f into neel/baggage-dsc-continuation Sep 27, 2022
@sl0thentr0py sl0thentr0py deleted the neel/baggage-dsc-head branch September 27, 2022 09:47
@sl0thentr0py sl0thentr0py modified the milestones: 5.5.0, Dynamic Sampling Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants