Add transaction source annotation #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/tx-source
branch
from
545e1a5
to
0c051de
Compare
Codecov ReportBase: 98.42% // Head: 98.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## neel/baggage-dsc-continuation #1902 +/- ##
=================================================================
+ Coverage 98.42% 98.43% +0.01%
=================================================================
Files 150 150
Lines 9183 9195 +12
=================================================================
+ Hits 9038 9051 +13
+ Misses 145 144 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Base automatically changed from
neel/baggage-dsc-head
to
neel/baggage-dsc-continuation
September 27, 2022 09:47
…nto neel/tx-source
st0012
reviewed
Sep 29, 2022
| @@ -18,7 +18,7 @@ class Event | |||
| event_id level timestamp | |||
| release environment server_name modules | |||
| message user tags contexts extra | |||
| fingerprint breadcrumbs transaction | |||
There was a problem hiding this comment.
It looks like a TransactionEvent-only attribute? If that's the case, can we put it there?
There was a problem hiding this comment.
I had it there first, but then moved it here because it's always coupled to the transaction field.
antonpirker
reviewed
Sep 29, 2022
st0012
reviewed
Sep 30, 2022
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| let(:client) { Sentry::Client.new(configuration) } | |||
| let(:hub) do | |||
| Sentry::Hub.new(client, subject) | |||
| Sentry::Hub.new(client, Sentry::Scope.new) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations for spec.
This is necessary going forward because we need to separate high cardinality / low quality (for us, only raw urls from rack) to enable ingestion to do metrics aggregation without blowing up.
Note: This is independent in principle, but I'm basing it off the baggage changes since all of this needs to go out together anyway and some of the
Transactionconstructors changed and would cause merge conflicts otherwise.closes #1866