Make transaction a required argument of Span #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification, a Span must has a Transaction, whether it's directly assigned to it or inherited from its parent Span. So this commit enforces that by requiring the `transaction:` argument on Span's constructor. Although it makes test setup a bit more complicated, it does make tests reflect our real-world expectation more accurately.
st0012
force-pushed
the
refactor-#1890
branch
from
9af3670
to
78bf9e7
Compare
Codecov ReportBase: 98.46% // Head: 98.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
- Coverage 98.46% 98.45% -0.01%
==========================================
Files 151 151
Lines 9258 9269 +11
==========================================
+ Hits 9116 9126 +10
- Misses 142 143 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sl0thentr0py
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, a Span must has a Transaction, whether it's directly assigned to it or inherited from its parent Span.
So this commit enforces that by requiring the
transaction:argument on Span's constructor.Although it makes test setup a bit more complicated, it does make tests reflect our real-world expectation more accurately.
Although this PR changes the constructor of the
SpanandTransactionclasses, they were never designed to be initialized directly by users. So this is not considered a breaking changeCloses #1890