Ignore redis key if not UTF8 #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Feb 6, 2023
| @@ -54,7 +54,8 @@ def commands_description | |||
| def parsed_commands | |||
| commands.map do |statement| | |||
| command, key, *arguments = statement | |||
| command_set = { command: command.to_s.upcase, key: key } | |||
| command_set = { command: command.to_s.upcase } | |||
| command_set[:key] = key if Utils::EncodingHelper.valid_utf_8?(key) | |||
There was a problem hiding this comment.
Since key is kinda important in commands, do you think it'd be better insert a placeholder like "<invalid encoded key>" instead?
There was a problem hiding this comment.
I think the type of redis command signifies that there's a key there, I think that's fine.
This is edge-case behaviour anyway.
st0012
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1992