Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the default number of background worker threads by half #2305

Merged
merged 2 commits into from
May 6, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented May 6, 2024

See #2297 for the discussion.

Closes #2297

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (09fa602) to head (e6c6197).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         203      203           
  Lines       13274    13282    +8     
=======================================
+ Hits        13105    13113    +8     
  Misses        169      169           
Components Coverage Δ
sentry-ruby 99.11% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.37% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (ø)
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.80% <100.00%> (ø)
sentry-ruby/spec/sentry/background_worker_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <100.00%> (ø)

@st0012 st0012 merged commit d0c9897 into master May 6, 2024
124 checks passed
@st0012 st0012 deleted the decrease-background-worker-threads branch May 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider avoiding Concurrent.processor_count when setting default background_worker_threads
2 participants