-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload coverage from all test runs #2430
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2430 +/- ##
==========================================
+ Coverage 98.70% 98.97% +0.26%
==========================================
Files 221 231 +10
Lines 14508 15094 +586
==========================================
+ Hits 14320 14939 +619
+ Misses 188 155 -33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to do this for all the _test
workflow files
@sl0thentr0py I had to fix some CI issues like bundler cache or fail-fast causing pre-mature job cancellations first via #2432 so please take a look there first :) |
00c382f
to
3764bf8
Compare
fd33918
to
5e36ec7
Compare
@sl0thentr0py doooooone, had a lot of weird issues with bundling delayed_job ending up with:
but after clearing bundle cache, it worked :) |
According to Codecov docs, merging reports works automatically (https://docs.codecov.com/docs/merging-reports) which means that if we just send multiple reports from all test runs, it'll merge them all. This PR shows that the coverage increased, so I guess it works?
#skip-changelog