Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage from all test runs #2430

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Oct 14, 2024

According to Codecov docs, merging reports works automatically (https://docs.codecov.com/docs/merging-reports) which means that if we just send multiple reports from all test runs, it'll merge them all. This PR shows that the coverage increased, so I guess it works?

#skip-changelog

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (d134d9e) to head (5e36ec7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
+ Coverage   98.70%   98.97%   +0.26%     
==========================================
  Files         221      231      +10     
  Lines       14508    15094     +586     
==========================================
+ Hits        14320    14939     +619     
+ Misses        188      155      -33     
Components Coverage Δ
sentry-ruby 99.14% <ø> (+0.12%) ⬆️
sentry-rails 98.46% <ø> (+1.02%) ⬆️
sentry-sidekiq 98.67% <ø> (+1.09%) ⬆️
sentry-resque 96.85% <ø> (-0.27%) ⬇️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 99.75% <ø> (-0.25%) ⬇️

see 113 files with indirect coverage changes

@solnic solnic requested review from st0012 and sl0thentr0py October 14, 2024 11:38
@solnic solnic marked this pull request as ready for review October 14, 2024 11:38
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to do this for all the _test workflow files

@solnic
Copy link
Collaborator Author

solnic commented Oct 15, 2024

@sl0thentr0py I had to fix some CI issues like bundler cache or fail-fast causing pre-mature job cancellations first via #2432 so please take a look there first :)

@solnic solnic force-pushed the solnic/merge-coverage-results branch 2 times, most recently from 00c382f to 3764bf8 Compare October 16, 2024 10:13
@solnic solnic force-pushed the solnic/merge-coverage-results branch from fd33918 to 5e36ec7 Compare October 16, 2024 11:42
@solnic solnic requested a review from sl0thentr0py October 16, 2024 11:42
@solnic
Copy link
Collaborator Author

solnic commented Oct 16, 2024

we need to do this for all the _test workflow files

@sl0thentr0py doooooone, had a lot of weird issues with bundling delayed_job ending up with:

rake aborted!
ArgumentError: wrong number of arguments (given 3, expected 2)
/home/runner/work/sentry-ruby/sentry-ruby/vendor/bundle/jruby/3.1.0/bundler/gems/activerecord-jdbc-adapter-6b3983bbbfda/Rakefile:355:in
`block in <main>'
/home/runner/work/sentry-ruby/sentry-ruby/vendor/bundle/jruby/3.1.0/bundler/gems/activerecord-jdbc-adapter-6b3983bbbfda/Rakefile:300:in
`block in <main>'
org/jruby/ext/monitor/Monitor.java:82:in `synchronize'
org/jruby/ext/monitor/Monitor.java:82:in `synchronize'
org/jruby/ext/monitor/Monitor.java:82:in `synchronize'
/home/runner/work/sentry-ruby/sentry-ruby/vendor/bundle/jruby/3.1.0/gems/rake-12.3.3/exe/rake:27:in

but after clearing bundle cache, it worked :)

@solnic solnic merged commit 76ede87 into master Oct 17, 2024
140 checks passed
@solnic solnic deleted the solnic/merge-coverage-results branch October 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants