Refactor Client #270
Merged
Refactor Client #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nateberkopec
commented
Dec 24, 2014
nateberkopec
commented
- remove redundant excluded environment check
- cleanup methods, esp. send
- remove redundant private
- remove unnecessary return statements, variable assignments
| else | ||
| raise Error.new("Unknown transport scheme '#{self.configuration.scheme}'") | ||
| raise "Unknown transport scheme '#{self.configuration.scheme}'" |
There was a problem hiding this comment.
This will cause it to raise RuntimeError instead of Raven::Error. It seems this code should be:
raise Error, "Unknown transport scheme '#{self.configuration.scheme}'"There was a problem hiding this comment.
Ai! Yes, definitely need to fix.
nateberkopec
force-pushed
the
refactor-2
branch
from
9392627
to
df5f3b0
Compare
|
Renaming should_send to should_capture is a fairly major API change. We may need to get serious about deprecation warnings. I know it's 0.X and all but I dunno. |
+ remove redundant excluded environment check + cleanup methods, esp. send + remove redundant private + remove unnecessary return statements, variable assignments + rename should_send/should_capture
nateberkopec
force-pushed
the
refactor-2
branch
from
df5f3b0
to
3d427dd
Compare
|
Deciding I'm going to roll with it for now. I'm going to try to keep patchlevel releases non-breaking, but minors may break things for as long as we're at 0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.