Refactor exit hook installation #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return unless configuration.should_send?(exception) | ||
| if (evt = Event.from_exception(exception, options)) | ||
| yield evt if block_given? | ||
| send(evt) |
There was a problem hiding this comment.
I'm not at all familiar with the async side of raven-ruby, but what happened to the async? conditional here?
There was a problem hiding this comment.
I moved it to the Client class: https://github.com/getsentry/raven-ruby/pull/272/files#diff-c6aec131e87f11962bba5dcfa61a07d9R31
nateberkopec
force-pushed
the
refactor-base
branch
from
fb94dca
to
ff8901d
Compare
nateberkopec
added a commit
that referenced
this pull request
Jan 16, 2015
Refactor exit hook installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the async tests are still failing - will need to fix.