Support exception chaining #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to the code, but any idea which version of Ruby started offering chaining? I didn't actually realize it was even a feature. |
|
Ignore that comment, I'm an idiot. The ticket actually points it out :) |
|
Thanks! Will take a look. |
|
Awesome. Just pushed up a fix to not check reporting when causes aren't supported. |
| exceptions.reverse! | ||
|
|
||
| exc_int.values = exceptions.map do |exc| | ||
| SingleExceptionInterface.new do |int| |
There was a problem hiding this comment.
Hmmm, I'm not really a fan of this name/a new class. Why can't you just use multiple instances of ExceptionInterface?
nateberkopec
added a commit
that referenced
this pull request
Apr 8, 2015
Support exception chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190