Ensure that the tags hierarchy is respected where event > context > configuration for tags using the same key #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration for tags using the same key.
|
Thanks! Good catch. |
nateberkopec
added a commit
that referenced
this pull request
May 4, 2015
Ensure that the tags hierarchy is respected where event > context > configuration for tags using the same key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the wiki, when talking about setting tags in the default configuration it sounded to me like you could override the values for each of the keys set in
tags.You can configure default tags to be sent with every event. These can be overridden in the context or event.With the way the tags are merged together currently, the priority of tags with the same key is context > configuration > event.
This seems wrong to me as I would think that if you set a tag explicitly in the event that is being sent to Sentry that it should take precedence over context and configuration tag values.
I've made a change to work the way I would imagine it should work.