Always return the Event object, regardless of what the async block returns.
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k returns. When using an `async` block, the capture methods would return the block returned value when called or the `Event` object when async isn't defined, which could possibly break any client code that would always expect the event object instead of a `ActiveJob::Base` instance or a `Sidekiq` job, for instance.
|
👍 for always returning the same type! |
nateberkopec
added a commit
that referenced
this pull request
Jun 5, 2015
Always return the `Event` object, regardless of what the `async` block returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an
asyncblock, the capture methods would return the block returned value when called or theEventobject when async isn't defined, which could possibly break any client code that would always expect the event object instead of aActiveJob::Baseinstance or aSidekiqjob, for instance.