-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix Rails multi-exception reports #422
WIP: Fix Rails multi-exception reports #422
Conversation
6809be8
to
cd2f174
Compare
950f77b
to
dda134f
Compare
ping @mattrobenolt This fixes the issue for the app you provided in #388, and, as far as I can tell, doesn't break any additional use cases. Can you take a look? |
Can also confirm this works correctly with |
👍 ❤️ |
I tested this locally, and it seems to record the wrong one now. It only logged one event, but it only logged the event wiht the url of |
For posterity, I ran against my docker container:
And mounted in this PR. Without mounting this in, it was recording the error twice. Now only records once, but the wrong one. |
dda134f
to
037baab
Compare
WIP: Fix Rails multi-exception reports
For posterity: I worked this out with @mattrobenolt and made sure the right exception was recorded. |
No description provided.