-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tower integration #356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuetuopay
force-pushed
the
tower-integration
branch
from
August 9, 2021 17:20
1b9e835
to
3d7538c
Compare
Tuetuopay
force-pushed
the
tower-integration
branch
from
August 9, 2021 17:47
3d7538c
to
644546f
Compare
Note about the clippy lint: it is bogus, the suggested fix does not compiles:
|
Swatinem
reviewed
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, thank you! Just some minor comments.
Tuetuopay
force-pushed
the
tower-integration
branch
from
August 12, 2021 08:50
110471b
to
7f7f7d9
Compare
Somehow this works locally and not in CI...
Swatinem
approved these changes
Aug 12, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a new
sentry-tower
subcrate which provides tower layers intended to bind Sentry hub to each request. This avoids mixing up breadcrumbs in each sentry event, to only keep those in the logical path that led to the captured event. It is best used in conjunction withsentry-log
orsentry-tracing
to automatically collect logs to breadcrumbs.It provides a ready to use
NewSentryLayer
, that creates a new hub from the currently active one and binds it for the duration of the service handler. It is based upon theSentryLayer
which is much more flexible, as it can take a hub directly or a closure producing hub. See thelib.rs
and test for usage example.Note that this could be expanded to automatically capture errors returned by the service, should it fail, though more design thought should be put into it.