-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded-svc based http transport #654
Add embedded-svc based http transport #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left a small suggestion for improvement
well, our CI runs with |
Thanks for the fast response! I will look into adding a sample esp32 project, so that the checks can pass. |
Had some issues adding a esp32 project to the workspace:
To get it "working" I made the embedded-svc-http feature do nothing if not compiling for a espidf based target. This has the side effect of effectively disabling CI for espidf. One solution would be to have a separate ci run with only the embedded-svc-http and a espidf target. Does that sound like an acceptable solution? |
This is perfect. Given it wouldn’t compile anyway with the feature flag, but without the proper
If it can be done with minimal effort, sure. Otherwise, I would rather treat this as a "tier3" platform or however you want to call it. In the sense that it exists, but "we" as the crate maintainers do not guarantee that it won’t break at some point in the future. |
embedded-svc is used on esp32 for doing https
Keeping it as tier3 is fine for me. If I find some spare time, I will try and create ci setup, but in an other PR. |
This small pr adds support for sending envelopes using the embedded-svc http transport available on the esp32 microcontroler.
With this in place it is possible to use sentry in rust (with std) based esp32 projects.