-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement record of tagged span data in tracing integration #696
Conversation
What's the reason behind putting these methods in Additionally, it looks like this is a change in behavior? Previously data would be added to the |
Because acquiring lock every time you need to add data point is pointless
There is no change in behavior, data is added in the same places as before @Swatinem Is this looking good then do you need unit tests? I looked over tracing layer and there is zero to none existing tests |
Is this crate still maintained? |
We often "abused" doctests to act as unit tests for a lot of things. Even though it would be good to have tests for this, I can also merge this without to speed things up here a bit. |
Is there any utility to create some sort of dummy/test setup for sentry in order to create transactions and read its data later? |
There is a test utility that will create a new sentry with a testing transport that captures all the envelopes/events happening within a scope. You should be able to use that. |
Created PR with basic test as follow up #703 |
This is prototype to attach tagged data for tracing spans
Please let me know if it is suitable and I'll see about unit tests if necessary
Fixes #653