added/updated tests

getsentry · Aug 27, 2021 · 137526c · 137526c
1 parent 9cbb6c0
commit 137526c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 7 deletions.
diff --git a/test/Sentry.Unity.Tests/SentryOptionsUtilityTests.cs b/test/Sentry.Unity.Tests/SentryOptionsUtilityTests.cs
@@ -51,6 +51,17 @@ public void SetDefaults_Environment_IsProductionOutsideEditor()
             Assert.AreEqual("production", options.Environment);
         }
 
+        [Test]
+        public void SetDefaults_Environment_IsProductionWhenBuilding()
+        {
+            var options = new SentryUnityOptions();
+            var application = new TestApplication(isEditor: true);
+
+            SentryOptionsUtility.SetDefaults(options, application, isBuilding: true);
+
+            Assert.AreEqual("production", options.Environment);
+        }
+
         [Test]
         public void SetDefaults_CacheDirectoryPath_IsPersistentDataPath()
         {
@@ -74,10 +85,12 @@ public void SetDefaults_IsEnvironmentUser_IsFalse()
         }
 
         [Test]
-        public void SetDefaults_OptionsCreated_AreEqual()
+        [TestCase(true)]
+        [TestCase(false)]
+        public void SetDefaults_OptionsCreated_AreEqual(bool isBuilding)
         {
             var expectedOptions = new SentryUnityOptions();
-            SentryOptionsUtility.SetDefaults(expectedOptions);
+            SentryOptionsUtility.SetDefaults(expectedOptions, isBuilding: isBuilding);
 
             var scriptableOptions = ScriptableObject.CreateInstance<ScriptableSentryUnityOptions>();
             SentryOptionsUtility.SetDefaults(scriptableOptions);
@@ -87,7 +100,7 @@ public void SetDefaults_OptionsCreated_AreEqual()
             scriptableOptions.DebugOnlyInEditor = false;
             scriptableOptions.DiagnosticLevel = SentryLevel.Debug;
 
-            var actualOptions = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions);
+            var actualOptions = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions, isBuilding);
 
             SentryUnityOptionsTests.AssertOptions(expectedOptions, actualOptions);
         }

diff --git a/test/Sentry.Unity.Tests/SentryUnityOptionsTests.cs b/test/Sentry.Unity.Tests/SentryUnityOptionsTests.cs
@@ -23,7 +23,9 @@ public void Options_ReadFromJson_Success()
         }
 
         [Test]
-        public void ToSentryUnityOptions_ValueMapping_AreEqual()
+        [TestCase(true)]
+        [TestCase(false)]
+        public void ToSentryUnityOptions_ValueMapping_AreEqual(bool isBuilding)
         {
             var expectedOptions = new SentryUnityOptions
             {
@@ -73,13 +75,15 @@ public void ToSentryUnityOptions_ValueMapping_AreEqual()
             scriptableOptions.DebugOnlyInEditor = expectedOptions.DebugOnlyInEditor;
             scriptableOptions.DiagnosticLevel = expectedOptions.DiagnosticLevel;
 
-            var optionsActual = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions);
+            var optionsActual = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions, isBuilding);
 
             AssertOptions(expectedOptions, optionsActual);
         }
 
         [Test]
-        public void ToScriptableOptions_ConvertJsonOptions_AreEqual()
+        [TestCase(true)]
+        [TestCase(false)]
+        public void ToScriptableOptions_ConvertJsonOptions_AreEqual(bool isBuilding)
         {
             var jsonTextAsset = new TextAsset(File.ReadAllText(GetTestOptionsFilePath()));
             var expectedOptions = JsonSentryUnityOptions.LoadFromJson(jsonTextAsset);
@@ -88,7 +92,7 @@ public void ToScriptableOptions_ConvertJsonOptions_AreEqual()
             SentryOptionsUtility.SetDefaults(scriptableOptions);
             JsonSentryUnityOptions.ToScriptableOptions(jsonTextAsset, scriptableOptions);
 
-            var actualOptions = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions);
+            var actualOptions = ScriptableSentryUnityOptions.ToSentryUnityOptions(scriptableOptions, isBuilding);
 
             AssertOptions(expectedOptions, actualOptions);
         }