Skip to content

Commit

Permalink
os.name is now os.raw_desc (#305)
Browse files Browse the repository at this point in the history
  • Loading branch information
bruno-garcia authored Sep 9, 2021
1 parent 2d72a16 commit 4f1c861
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Features

- Operating System reported as raw_description and parsed by Sentry ([#305](https://github.com/getsentry/sentry-unity/pull/305))
- Release & Environment now sync with native options ([#298](https://github.com/getsentry/sentry-unity/pull/298))
- Bump Sentry .NET SDK 3.9.0 ([#299](https://github.com/getsentry/sentry-unity/pull/299))
- [changelog](https://github.com/getsentry/sentry-dotnet/blob/3.9.0/CHANGELOG.md)
Expand Down
3 changes: 1 addition & 2 deletions src/Sentry.Unity/UnityEventProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ private void PopulateApp(App app)

private void PopulateOperatingSystem(OperatingSystem operatingSystem)
{
// TODO: Will move to raw_description once parsing is done in Sentry
operatingSystem.Name = _mainThreadData.OperatingSystem;
operatingSystem.RawDescription = _mainThreadData.OperatingSystem;
}

private void PopulateDevice(Device device)
Expand Down
2 changes: 1 addition & 1 deletion test/Sentry.Unity.Tests/UnityEventProcessorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ public IEnumerator Process_OperatingSystemProtocol_Assigned()
sut.Process(sentryEvent);

// assert
Assert.AreEqual(_sentryMonoBehaviour.SentrySystemInfo.OperatingSystem, sentryEvent.Contexts.OperatingSystem.Name);
Assert.AreEqual(_sentryMonoBehaviour.SentrySystemInfo.OperatingSystem, sentryEvent.Contexts.OperatingSystem.RawDescription);
}

[UnityTest]
Expand Down

0 comments on commit 4f1c861

Please sign in to comment.