Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity logged exceptions should be marked as unhandled by default #532

Closed
bruno-garcia opened this issue Jan 25, 2022 · 5 comments
Closed
Labels
Documentation Feature New feature or request

Comments

@bruno-garcia
Copy link
Member

It seems not to be possible to distinguish between a user calling Debug.LogException and an unhandled exception we capture through the Unity logging integration. Because of that, we've historically didn't mark any of those as Unhandled. The product a lot of distinctions between those, giving more emphasis to unhandled exceptions, as they have more user impact.

We should turn any exception logged through Debug.LogException into unhandled and document that users should use SentrySdk.CaptureException instead.

Remove any usage of Debug.LogException from the docs. Other than in Troubleshooting docs where we can explain the difference between calling either API and handled/unhandled exceptions.

@ripperdoc
Copy link

This also seems to apply to LogError, so that any LogError shows up as unhandled. Is that expected too?

@bitsandfoxes
Copy link
Contributor

This also seems to apply to LogError, so that any LogError shows up as unhandled. Is that expected too?

Yes, we treat the Unity logTypes Error, Exception, and Assertas equal in this case and mark the resulting event as unhandled.

@bitsandfoxes
Copy link
Contributor

Yes, we treat the Unity logTypes Error, Exception, and Assertas equal in this case and mark the resulting event as unhandled.

@oddgames-david
Copy link

This is backwards to all other bug capture sdk's I've used. If you are logging it you have handled it and it's just for informational purposes. Anything that is thrown and not caught is unhandled.

@bruno-garcia
Copy link
Member Author

What's the strategy used by the sdks to mark something as unhandled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants