Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Marking Unity exceptions as unhandled by default #542

Merged
merged 8 commits into from
Feb 4, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Resolving #532

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f3386c7

@SimonCropp
Copy link
Contributor

can a test be added that actually throws an exception and assert that is it captured with the correct mechanism?

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will need some documentation though.

@bruno-garcia bruno-garcia merged commit 458de9d into main Feb 4, 2022
@bruno-garcia bruno-garcia deleted the feat/unity-exceptions-unhandled branch February 4, 2022 04:36
@bruno-garcia
Copy link
Member

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.
Generated by 🚫 dangerJS against f3386c7

yes please

@bitsandfoxes
Copy link
Contributor Author

Waiting to be merged on the next release: getsentry/sentry-docs#4677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants