chore(deps): update .NET SDK to v3.22.0 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
bitsandfoxes and
vaind
as code owners
bruno-garcia
force-pushed
the
deps/src/sentry-dotnet/3.22.0
branch
from
bc6bebd
to
32f5ae7
Compare
bitsandfoxes
reviewed
Oct 7, 2022
| @@ -139,7 +139,7 @@ public static void SmokeTest() | |||
| t.ExpectMessage(currentMessage, "'message':'scope-crumb'}"); | |||
| t.ExpectMessage(currentMessage, "'extra':{'extra-key':42}"); | |||
| t.ExpectMessage(currentMessage, "'tag-key':'tag-value'"); | |||
| t.ExpectMessage(currentMessage, "'user':{'email':'email@example.com','id':'user-id','ip_address':'::1','username':'username','other':{'role':'admin'}}"); | |||
| t.ExpectMessage(currentMessage, "'user':{'id':'user-id','username':'username','email':'email@example.com','ip_address':'::1','other':{'role':'admin'}}"); | |||
There was a problem hiding this comment.
The change of order came from SentryTargets.cs here: https://github.com/getsentry/sentry-dotnet/pull/1920/files
There was a problem hiding this comment.
Yeah, that should be fine. Thanks for pointing that out!
bitsandfoxes
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps src/sentry-dotnet from 3.21.0 to 3.22.0.
Auto-generated by a dependency updater.
Changelog
3.22.0
Features
SentryOptions.AttachStackTraceis now enabled by default. (#1907)TransactionNameSourceannotation (#1910)User.Segmentproperty (#1920)JsonConverters (#1934)Fixes
AggregateException(#1924)okinstead ofunknown_error(#1970)