Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: screenshot orientation on some devices #1019

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 17, 2022

replaces #1017
fixes #935

Tested manually on Unity 2021: mac (editor & player), iOS & Android; Unity 2019: Windows (editor & player), Linux

@bitsandfoxes can you check the device reported to be broken in the issue?

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the OnePlus Nord 2 available anymore but it seems to work on all the other devices I could test it on.

Co-authored-by: Stefan Jandl <reg@bitfox.at>
@vaind vaind merged commit 7558280 into main Oct 18, 2022
@vaind vaind deleted the fix/screenshot-mirroring-v2 branch October 18, 2022 10:30
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- screenshot orientation on some devices ([#1019](https://github.com/getsentry/sentry-unity/pull/1019))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against aebe740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots on Android sometimes flipped
2 participants