Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled Android lifecycle breadcrumbs #1038

Merged
merged 2 commits into from
Oct 24, 2022
Merged

fix: Disabled Android lifecycle breadcrumbs #1038

merged 2 commits into from
Oct 24, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Oct 24, 2022

Resolves #1037
Typo.
Might be worth considering adding a list of "packages that might/do create friction" to the smoketest?

@@ -343,7 +343,7 @@ internal void SetAutoSessionTracking(bool enableAutoSessionTracking)
=> SetMetaData($"{SentryPrefix}.auto-session-tracking.enable", enableAutoSessionTracking.ToString());

public void SetAutoAppLifecycleBreadcrumbs(bool enableAutoAppLifeCycleBreadcrumbs)
=> SetMetaData($"{SentryPrefix}.bbreadcrumbs.app-lifecycle", enableAutoAppLifeCycleBreadcrumbs.ToString());
=> SetMetaData($"{SentryPrefix}.breadcrumbs.app-lifecycle", enableAutoAppLifeCycleBreadcrumbs.ToString());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 👍

@bitsandfoxes bitsandfoxes merged commit a18181f into main Oct 24, 2022
@bitsandfoxes bitsandfoxes deleted the fix/fix branch October 24, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Compatible with Google Admob 7.2.0
2 participants