Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed build guid from Release #1127

Merged
merged 7 commits into from
Jan 6, 2023
Merged

fix: Removed build guid from Release #1127

merged 7 commits into from
Jan 6, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Problem statement:
The build GUID is not available during build. So the release we set in the native SDKs during build time does not match the release during runtime.

I tried looking into retrieving the build GUID during the build process from BuildReport.BuidSummary.guid but that one does not seem to match Application.buildGuid of the app?

@vaind vaind merged commit 03c8db1 into main Jan 6, 2023
@vaind vaind deleted the fix/releases branch January 6, 2023 11:45
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Removed build guid from `Release` ([#1127](https://github.com/getsentry/sentry-unity/pull/1127))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9735e87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants