fix: Uploading all .pdb at Temp/ManagedSymbols for Mono on Windows & Linux
#1226
Conversation
| @@ -178,7 +178,7 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar | |||
|
|
|||
| if (isMono) | |||
| { | |||
| addFilesMatching($"{projectDir}/Temp", new[] { "**/UnityEngine.*.pdb", "**/Assembly-CSharp.pdb" }); | |||
There was a problem hiding this comment.
Are you sure the original files are still matched for all supported versions of Unity?
I remember some of these rules (not saying it relates to this one specifically) being very different for each version I've tested this on.
Maybe instead just add the new rule instead of removing the old one unless you've verified we're not losing useful files.
There was a problem hiding this comment.
I double checked and at the very least for Windows this works.
Line numbers on OSX and mono don't work right now. And that directory does not exist either. Checking for Linux.
bitsandfoxes
changed the title
.pdb at Temp/ManagedSymbols for Mono.pdb at Temp/ManagedSymbols for Mono on Windows
bitsandfoxes
changed the title
.pdb at Temp/ManagedSymbols for Mono on Windows.pdb at Temp/ManagedSymbols for Mono on Windows & Linux
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Uploading all `.pdb` at `Temp/ManagedSymbols` for Mono on Windows & Linux ([#1226](https://github.com/getsentry/sentry-unity/pull/1226))If none of the above apply, you can opt out of this check by adding |
Unity allows for the use of Assembly Definitions which leads to the creation of separate
.dlland.pdbfiles. Currently, those get skipped due to the naming restriction.