Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump dotnet 3.3.4 #132

Merged
merged 5 commits into from
Apr 26, 2021
Merged

bump dotnet 3.3.4 #132

merged 5 commits into from
Apr 26, 2021

Conversation

bruno-garcia
Copy link
Member

Superceed #126

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- bump dotnet 3.3.4(#132)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against 5de074d

@bruno-garcia
Copy link
Member Author

This was rebased from main and still fails. Not sure yet what's going on, need investigating

@bruno-garcia bruno-garcia merged commit 6d63b8e into main Apr 26, 2021
@bruno-garcia bruno-garcia deleted the chore/bump-dotnet-3.3.4 branch April 26, 2021 20:21
@semuserable
Copy link
Contributor

After previous problems with il2cpp, have you checked it on il2cpp before merging? :)

@bruno-garcia
Copy link
Member Author

@semuserable IL2WHAT?

@bruno-garcia
Copy link
Member Author

Sorry, I didn't. But the fixes there are trivial.
I hope we land the IL2CPP test soon to help with these checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semuserable semuserable semuserable approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruno-garcia @semuserable