feat: Filter Unity telemetry BadGatewayException on iOS native layer
#1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
BadGatewayException filtering to native layerBadGatewayException on iOS native layer
|
vaind
reviewed
May 30, 2023
bruno-garcia
approved these changes
May 30, 2023
| @@ -139,6 +139,11 @@ public new CompressionLevelWithAuto RequestBodyCompressionLevel | |||
| /// </summary> | |||
| public TimeSpan AnrTimeout { get; set; } = TimeSpan.FromSeconds(5); | |||
|
|
|||
| /// <summary> | |||
| /// Whether the SDK should automatically filter `Bad Gateway Exceptions` caused by Unity. | |||
There was a problem hiding this comment.
Above it indicates that it does this only work for iOS. Should we indicate this in the docs here?
Suggested change
| /// Whether the SDK should automatically filter `Bad Gateway Exceptions` caused by Unity. | |
| /// Whether the SDK should automatically filter `BadGatewayException` caused by Unity on iOS. |
There was a problem hiding this comment.
There are a whole bunch of places these exceptions are coming from. We already filter them on the C# layer but now, with the same flag because it's the same noise, we also filter the ones coming from native iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had filtering of
BadGatewayExceptionson the C# layer. If enabled, these need to be propagated down to the native layer as well.