Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xcode build with iOS native support disabled #1352

Merged
merged 9 commits into from
Jun 5, 2023
Merged

Conversation

bitsandfoxes
Copy link
Contributor

The Unity SDK expects the bridge to be there and the Xcode build fails during linking.
We now copy a no-op bridge to the output project when the iOS native support is disabled.

@bitsandfoxes bitsandfoxes requested a review from vaind June 1, 2023 07:18
@bitsandfoxes bitsandfoxes merged commit d545adf into main Jun 5, 2023
@bitsandfoxes bitsandfoxes deleted the fix/xcode branch June 5, 2023 13:15
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Xcode build with iOS native support disabled ([#1352](https://github.com/getsentry/sentry-unity/pull/1352))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1bb205c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants