Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove bitcode check from iOS builds #1381

Merged
merged 2 commits into from
Jun 22, 2023
Merged

feat: Remove bitcode check from iOS builds #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2754bf
updated upload script for build phase
bitsandfoxes Jun 21, 2023
acacfd1
Updated CHANGELOG.md
bitsandfoxes Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
- Suspending Android native support for Mono builds to prevent C# exceptions form causing crashes ([#1362](https://github.com/getsentry/sentry-unity/pull/1362))
- Fixed an issue where the debug image UUID normalization would malform the UUID leading to a failed symbolication ([#1361](https://github.com/getsentry/sentry-unity/pull/1361))

### Feature

- When building for iOS, the debug symbol upload now works irrespective of whether `Bitcode` is enabled or not ([#1381](https://github.com/getsentry/sentry-unity/pull/1381))

### Dependencies

- Bump .NET SDK from v3.33.0 to v3.33.1 ([#1370](https://github.com/getsentry/sentry-unity/pull/1370))
Expand Down
12 changes: 3 additions & 9 deletions src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,11 @@ internal class SentryXcodeProject : IDisposable
}}

export SENTRY_PROPERTIES=sentry.properties
if [ ""$ENABLE_BITCODE"" = ""NO"" ] ; then
echo ""Uploading debug symbols (Bitcode disabled).""
if [ ""$ACTION"" = ""install"" ] ; then
echo ""Uploading debug symbols and bcsymbolmaps.""
process_upload_symbols
else
echo ""Bitcode is enabled""
if [ ""$ACTION"" = ""install"" ] ; then
echo ""Uploading debug symbols and bcsymbolmaps (Bitcode enabled).""
process_upload_symbols
else
echo ""Skipping debug symbol upload because Bitcode is enabled and this is a non-install build.""
fi
echo ""Skipping debug symbol upload because this is a non-install build.""
fi
";

Expand Down