change gradle task syntax and placement

[munkiki7]

Reason for changes: random android smoke tests failures during CI tasks.

We have noticed that sometimes the upload task is executed before the assemble task is finished, which resulted in not all .so files being generated at the moment it was executed. After that the uploaded symbols validation was failing.

Now we are attaching the symbol upload task to either assembleDebug or assembleRelease tasks of the launcher build.gradle instead of the root build.gradle file.

One of the other advantages is that with the previous approach the symbol upload task was executed during the gradle sync process in the Android Studio (if the project was exported), as it was bound to the last task being executed (even though it was not a build-related task).

Previous syntax:

gradle.taskGraph.whenReady { taskGraph ->
    gradle.taskGraph.allTasks[-1].doLast { task ->
        //task body
    }
}

New syntax (needs to be wrapped in the afyterEvaluate call, because we have to wait until the task list is built):

afterEvaluate {
    task sentryUploadSymbols {
        doLast {
            //task body
        }
    }
    
    tasks.assembleDebug.finalizedBy sentryUploadSymbols
    tasks.assembleRelease.finalizedBy sentryUploadSymbols
}

[bitsandfoxes]

Where is the change to the path coming from?

[bitsandfoxes]

Ah, I see. Because the SDK now modifies the launcher/build.gradle. Why?

[munkiki7]

The task is now added to the topmost project - launcher that depends on unityFramework target.

We are now executing the symbol upload task after the assembleDebug or assembleRelease tasks, which do not exist in the scope of the build.gradle file we were modifying previously.

[bitsandfoxes]

Instead of messing with the path, can we just drop the cli executable and the .properties next to the launcher gradle file?

[munkiki7]

That depends on whether anything else is also using the locations of those files. But we can check.

[bitsandfoxes]

Sentry CLI is the one looking for the .properties so I think it's safe to keep all that in once place.

[bitsandfoxes]

Thanks for tackling this!