fix: User ID fallback on mobile #1710
Conversation
| using System; | ||
|
|
||
| namespace Sentry.Unity.Android | ||
| { |
There was a problem hiding this comment.
can u use top level namespace here already?
There was a problem hiding this comment.
I might, but everything in that .csproj is inside the Sentry.Unity.Android namespace.
There was a problem hiding this comment.
I just mean 'top level namespace'
| // In case we can't get an installation ID we create one and sync that down to the native layer | ||
| options.DiagnosticLogger?.LogDebug("Failed to fetch 'Installation ID' from the native SDK. Creating new 'Default User ID'."); | ||
|
|
||
| options.DefaultUserId = AnalyticsSessionInfo.userId; |
There was a problem hiding this comment.
AnalyticsSessionInfo.userId
Is this something devs would need to add to their app manifest now? Might be a problem to use something that can be used to track users across apps. That's why we use our own guid everywhere
There was a problem hiding this comment.
I picked AnalyticsSessionInfo.userId as we currently use it for the desktop platforms. It's a GUID generated during installation. Based on the Unity Docs it only gets regenerated during a re-install.
For the Unity SDK to use the .NET SDKs installation ID we'd need to make that public.
https://github.com/getsentry/sentry-dotnet/blob/d88635187ba02b4e47906a38b5bc0ebb19548355/src/Sentry/SentryOptions.cs#L46
There was a problem hiding this comment.
oh OK, so it uses the same principal as we do.
Worth adding a big block of comment clarifying that btw for anyone reasing the code and being worried about tracking and privacy
|
The user confirmed that the build from this PR fixed the issue for them. |
User reported events without any user ID coming from the C# layer. This should work out of the box. In case of
user.Idbeing null theenricherwould set the installation ID.https://github.com/getsentry/sentry-dotnet/blob/82dcbcdadaf37670729b394bf47489cc73fc7aa1/src/Sentry/Internal/Enricher.cs#L83
But if the ID was an empty string, it would not get overwritten by the enricher, it would not get serialized, and it would not show up on the issue.
To prevent those edge-cases I added fallbacks to both Android and iOS, relying on the same mechanism as we do on desktop to create a new ID and pass it down.