Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition scene to test scene loading events (breadcrumbs) #185

Merged
merged 8 commits into from
May 27, 2021

Conversation

semuserable
Copy link
Contributor

@semuserable semuserable commented May 18, 2021

  • New TransitionScene with two buttons: load BugFarmScene and ThrowNull.
  • New button (Load TransitionScene) in BugFarmScene

Now can test load scene events.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have multiple scenes we could rename them to BugFarmLevel_1 / Level_2 respectively. Other than us noone knows what a "TransitionScene" is and what it's for. With the numeric postfix there is an implied hierarchy that helps with self documenting.

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented May 18, 2021

This is nitpicking but please reset the transform on the TransitionScene/Scripts GameObject.

@semuserable
Copy link
Contributor Author

semuserable commented May 18, 2021

Now that we have multiple scenes we could rename them to BugFarmLevel_1 / Level_2 respectively. Other than us noone knows what a "TransitionScene" is and what it's for. With the numeric postfix there is an implied hierarchy that helps with self documenting.

I have no strict preference to naming the scenes, but I prefer to give descriptive names. "Us" is developers who develop the package, so "we" understand what "TransitionScene" means. We can also document it.

@bitsandfoxes
Copy link
Contributor

Now that we have multiple scenes we could rename them to BugFarmLevel_1 / Level_2 respectively. Other than us noone knows what a "TransitionScene" is and what it's for. With the numeric postfix there is an implied hierarchy that helps with self documenting.

I have no strict preference to naming the scenes, but I prefer to give descriptive names. "Us" is developers who develop the package, so "we" understand what "TransitionScene" means. We can also document it.

But it's not just "us developers" who get to see and use it, right? We ship it as sample with our package to users. And they should not need to read the documentation to know which scene is the first they should want to open.

@semuserable
Copy link
Contributor Author

Now that we have multiple scenes we could rename them to BugFarmLevel_1 / Level_2 respectively. Other than us noone knows what a "TransitionScene" is and what it's for. With the numeric postfix there is an implied hierarchy that helps with self documenting.

I have no strict preference to naming the scenes, but I prefer to give descriptive names. "Us" is developers who develop the package, so "we" understand what "TransitionScene" means. We can also document it.

But it's not just "us developers" who get to see and use it, right? We ship it as sample with our package to users. And they should not need to read the documentation to know which scene is the first they should want to open.

As I was saying, I have no strong preference about scene namings. If in Unity community it's better to name scenes like Level_n, then sure, let's do that.

@semuserable
Copy link
Contributor Author

semuserable commented May 26, 2021

Updated.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants